Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate History.pvl #662

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Reinstate History.pvl #662

merged 3 commits into from
Jul 19, 2021

Conversation

bobismijnnaam
Copy link
Contributor

Changes to get History.pvl working again:

  • Ensure RandomizedIf introduces random methods properly (call them with a "this" argument, and generate final methods).
  • Also ensure any recursive calls generated by left_merge in CheckProcessAlgebra have a this argument.
  • Remove problem-fail from the two cases in History.pvl

@bobismijnnaam
Reinstate History.pvl
b582b8a 
Ensure RandomizedIf introduces random methods properly (call them with a
"this" argument, and generate final methods).

Also ensure any recursive calls generated by left_merge in
CheckProcessAlgebra have a this argument.
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 16, 2021 08:36 Inactive
@bobismijnnaam bobismijnnaam mentioned this pull request Jul 16, 2021
Merged
24 tasks
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 16, 2021 08:54 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 16, 2021 08:55 Inactive
@Vescatur
Copy link
Contributor

Vescatur commented Jul 16, 2021 •
edited
Loading

Nice work getting it working again. Do you think it is possible to do a null check for create.invokation? If not then you can merge it.

Vescatur
Vescatur requested changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@Vescatur Vescatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work getting it working again. Do you think it is possible to do a null check for create.invokation? If not then you can merge it.

@bobismijnnaam
Copy link
Contributor Author

Do you think it is possible to do a null check for create.invokation?

Do you mean, inside the definition of create.invokation (so, in ASTFactory.java), check if the first argument is null? I think leaving it null indicates it is a free method call, i.e., not on an object or something but a top-level function call. So null is in fact allowed, it's just not what we want in this case.

@bobismijnnaam bobismijnnaam temporarily deployed to Default July 19, 2021 11:54 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 19, 2021 11:54 Inactive
@bobismijnnaam
Copy link
Contributor Author

After some discussion with @Vescatur we decided to merge this after the tests pass.

@bobismijnnaam bobismijnnaam temporarily deployed to Default July 19, 2021 12:09 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 19, 2021 12:14 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bobismijnnaam bobismijnnaam merged commit bd79721 into dev Jul 19, 2021
@bobismijnnaam bobismijnnaam deleted the reinstate-history-pvl branch July 19, 2021 12:29
@Vescatur
Copy link
Contributor

Nice work getting it working again. Do you think it is possible to do a null check for create.invokation? If not then you can merge it.

It is not possible to do a null check because null is a valid value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vescatur Vescatur Vescatur requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobismijnnaam @Vescatur